Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Minor fixes to arithmetic operations with scalar and tensors #2276

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

mloubout
Copy link
Contributor

@mloubout mloubout commented Dec 6, 2023

On top of #2275

@mloubout mloubout added the API api (symbolics, types, ...) label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1bf0991) 86.83% compared to head (582c39c) 77.48%.

Files Patch % Lines
devito/types/equation.py 40.00% 3 Missing ⚠️
devito/types/basic.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2276      +/-   ##
==========================================
- Coverage   86.83%   77.48%   -9.36%     
==========================================
  Files         229      222       -7     
  Lines       42435    41853     -582     
  Branches     7868     7831      -37     
==========================================
- Hits        36850    32430    -4420     
- Misses       4926     8717    +3791     
- Partials      659      706      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@FabioLuporini FabioLuporini merged commit 310226e into master Dec 7, 2023
31 checks passed
@FabioLuporini FabioLuporini deleted the recipes-tweaks branch December 7, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API api (symbolics, types, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants