mpi: Fix haloupdate with inner dim [v2] #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2272 +/- ##
==========================================
+ Coverage 86.80% 86.82% +0.02%
==========================================
Files 229 229
Lines 42296 42383 +87
Branches 7830 7845 +15
==========================================
+ Hits 36713 36797 +84
- Misses 4923 4926 +3
Partials 660 660 ☔ View full report in Codecov by Sentry. |
mloubout
approved these changes
Nov 21, 2023
| def process(self, clusters): | ||
| return self._process_fatd(clusters, 1, seen=set()) | ||
|
|
||
| def callback(self, clusters, prefix, seen=None): | ||
| if seen.issuperset(clusters): | ||
| if not prefix: |
There was a problem hiding this comment.
Should this be both not prefix or seen.issuperset(clusters) ?
There was a problem hiding this comment.
no the seen check is performed a few lines below on a per-cluster basis
mloubout
force-pushed
the
halo-inner-dim-fabio
branch
from
bfa0fec
to
d6d8a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.