Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reqs: Move pyrevolve to optionals and introduce testing-only reqs #2096

Merged
merged 4 commits into from
May 4, 2023

Conversation

georgebisbas
Copy link
Contributor

No description provided.

@georgebisbas georgebisbas added the dependencies Pull requests that update a dependency file label Mar 30, 2023
requirements.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@georgebisbas georgebisbas force-pushed the refactor_reqs branch 2 times, most recently from e7a10ca to 14153aa Compare March 30, 2023 13:15
@mloubout mloubout force-pushed the refactor_reqs branch 2 times, most recently from 47792f6 to 24a3b62 Compare March 30, 2023 14:06
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #2096 (b3d6f05) into master (5ed93c1) will decrease coverage by 0.34%.
The diff coverage is 97.22%.

@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
- Coverage   87.48%   87.15%   -0.34%     
==========================================
  Files         220      220              
  Lines       39280    39300      +20     
  Branches     5113     5113              
==========================================
- Hits        34365    34251     -114     
- Misses       4346     4478     +132     
- Partials      569      571       +2     
Impacted Files Coverage Δ
examples/seismic/viscoacoustic/wavesolver.py 80.37% <ø> (-19.63%) ⬇️
devito/checkpointing/__init__.py 92.85% <92.85%> (-7.15%) ⬇️
devito/__init__.py 94.36% <100.00%> (+0.52%) ⬆️
examples/seismic/acoustic/wavesolver.py 87.50% <100.00%> (-12.50%) ⬇️
examples/seismic/tti/wavesolver.py 89.91% <100.00%> (-8.42%) ⬇️
tests/conftest.py 84.27% <100.00%> (+1.47%) ⬆️
tests/test_checkpointing.py 59.71% <100.00%> (-40.29%) ⬇️
tests/test_gradient.py 91.27% <100.00%> (-7.39%) ⬇️

... and 2 files with indirect coverage changes

@mloubout mloubout force-pushed the refactor_reqs branch 3 times, most recently from 2aa42d1 to c682d38 Compare March 30, 2023 14:34
tests/conftest.py Show resolved Hide resolved
devito/__init__.py Outdated Show resolved Hide resolved
@mloubout mloubout force-pushed the refactor_reqs branch 8 times, most recently from a5611fc to 56a16d1 Compare May 3, 2023 17:41
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks a lot.

pip install -e .
pip install matplotlib
pip install -e .[tests]
pip install matplotlib pyrevolve
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that ensure that we install the latest versions?
e.g. this is why we "cannot" see the maptlolib issue in our CI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip always install the latest compatible version.

tests/conftest.py Show resolved Hide resolved
@mloubout mloubout merged commit ff58795 into master May 4, 2023
@mloubout mloubout deleted the refactor_reqs branch May 4, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants