Use related nodes api instead of failing duplicate landmarks

lib/checks/landmarks/landmark-is-unique-after.js

@@ -1,5 +1,5 @@
 const uniqueLandmarks = [];
-results.forEach(currentResult => {
+return results.filter(currentResult => {
 	const findMatch = someResult => {
 		return (
 			currentResult.data.role === someResult.data.role &&
@@ -10,10 +10,12 @@ results.forEach(currentResult => {
 	const foundResultIndex = uniqueLandmarks.findIndex(findMatch);
 	if (foundResultIndex === -1) {
 		uniqueLandmarks.push(currentResult);
+		currentResult.relatedNodes = [];
+		return true;
 	} else {
-		currentResult.result = false;
-		uniqueLandmarks[foundResultIndex].result = false;
+		const matchedResult = uniqueLandmarks[foundResultIndex];
+		matchedResult.result = false;
+		matchedResult.relatedNodes.push(currentResult.relatedNodes[0]);
+		return false;
 	}
 });
-
-return results;

lib/checks/landmarks/landmark-is-unique.js

@@ -2,5 +2,6 @@ let role = axe.commons.aria.getRole(node);
 let label = axe.commons.aria.label(node);
 label = label ? label.toLowerCase() : null;
 this.data({ role: role, label: label });
+this.relatedNodes([node]);
 
 return true;

test/checks/landmarks/landmark-is-unique-after.js

@@ -1,50 +1,84 @@
 describe('landmark-is-unique-after', function() {
 	'use strict';
 
+	var checkContext = axe.testUtils.MockCheckContext();
 	function createResult(result, data) {
 		return {
 			result: result,
 			data: data
 		};
 	}
 
+	function createResultWithSameRelatedNodes(result, data) {
+		return {
+			...createResult(result, data),
+			relatedNodes: [createResult(result, data)]
+		};
+	}
+
+	function createResultWithProvidedRelatedNodes(result, data, relatedNodes) {
+		return {
+			...createResult(result, data),
+			relatedNodes
+		};
+	}
+
+	afterEach(function() {
+		axe._tree = undefined;
+		checkContext.reset();
+	});
+
 	it('should update duplicate landmarks with failed result', function() {
 		var result = checks['landmark-is-unique'].after([
-			createResult(true, {
+			createResultWithSameRelatedNodes(true, {
 				role: 'some role',
 				label: 'some label'
 			}),
-			createResult(true, {
+			createResultWithSameRelatedNodes(true, {
 				role: 'some role',
 				label: 'some label'
 			}),
-			createResult(true, {
+			createResultWithSameRelatedNodes(true, {
 				role: 'different role',
 				label: 'some label'
 			}),
-			createResult(true, {
+			createResultWithSameRelatedNodes(true, {
 				role: 'some role',
 				label: 'different label'
 			})
 		]);
 
-		assert.deepEqual(result, [
-			createResult(false, {
-				role: 'some role',
-				label: 'some label'
-			}),
-			createResult(false, {
-				role: 'some role',
-				label: 'some label'
-			}),
-			createResult(true, {
-				role: 'different role',
-				label: 'some label'
-			}),
-			createResult(true, {
-				role: 'some role',
-				label: 'different label'
-			})
-		]);
+		const expectedResult = [
+			createResultWithProvidedRelatedNodes(
+				false,
+				{
+					role: 'some role',
+					label: 'some label'
+				},
+				[
+					createResult(true, {
+						role: 'some role',
+						label: 'some label'
+					})
+				]
+			),
+			createResultWithProvidedRelatedNodes(
+				true,
+				{
+					role: 'different role',
+					label: 'some label'
+				},
+				[]
+			),
+			createResultWithProvidedRelatedNodes(
+				true,
+				{
+					role: 'some role',
+					label: 'different label'
+				},
+				[]
+			)
+		];
+		assert.deepEqual(result, expectedResult);
 	});
 });

test/integration/rules/landmark-unique/landmark-unique-fail.json

@@ -3,18 +3,11 @@
 	"rule": "landmark-unique",
 	"violations": [
 		["#violation-main-1"],
-		["#violation-main-2"],
 		["#violation-header-1"],
-		["#violation-header-2"],
 		["#violation-form-aria-label-1"],
-		["#violation-form-aria-label-2"],
 		["#violation-form-aria-labelledby-1"],
-		["#violation-form-aria-labelledby-2"],
 		["#violation-aside-aria-label-1"],
-		["#violation-aside-aria-label-2"],
 		["#violation-aside-aria-labelledby-1"],
-		["#violation-aside-aria-labelledby-2"],
-		["#violation-footer-1"],
-		["#violation-footer-2"]
+		["#violation-footer-1"]
 	]
 }