feat(rule): Adding landmark-is-unique rule #1394

waabid · 2019-02-28T01:01:13Z

The rule checks for whether rules are unique. The structure is:

matches + selectors: identify landmarks.
evaluate: passes all nodes and adds role/label data.
after: fails all landmarks that have duplicate roles and labels.

Linked issue: #866

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

Follows the commit message policy, appropriate for next version
Has documentation updated, a DU ticket, or requires no documentation change
Includes new tests, or was unnecessary
Code is reviewed for security by: @WilcoFiers

Merge from deque/axe-core

…develop

…users/waabid/uniqueLandmarks2

CLAassistant · 2019-02-28T01:01:21Z

All committers have signed the CLA.

dylanb

I have not reviewed the tests yet in detail because there are more changes needed.

we need an iframe test
We need a shadowDOM test
please address the comments

lib/checks/landmarks/landmark-is-unique-after.js

lib/rules/landmark-unique-matches.js

…abid/axe-core into users/waabid/uniqueLandmarks2

…mark-unique-matches

…adow dom

jeeyyy

Left inline comments, yet to review the tests.

lib/checks/landmarks/landmark-is-unique-after.js

lib/checks/landmarks/landmark-is-unique.js

lib/rules/landmark-unique-matches.js

test/integration/rules/landmark-unique/frame.html

test/rule-matches/landmark-unique-matches.js

lib/rules/landmark-unique-matches.js

…andmarks2

dylanb · 2019-04-12T19:10:48Z

@waabid @WilcoFiers how can I help move this PR along?

…andmarks2

waabid · 2019-04-18T18:51:44Z

@waabid @WilcoFiers how can I help move this PR along?

I've addressed all comments; had some tests breaking but fixed those. Now the test build is broken due to a dependency I believe.

WilcoFiers · 2019-05-17T09:28:14Z

Closing this as a duplicate of #1394

WilcoFiers · 2019-05-17T09:29:12Z

Whoops, I meant the other way around.

…queLandmarks2

Pr in working state, I believe changes were addressed

WilcoFiers

Couple of minor points

lib/rules/landmark-unique-matches.js

test/rule-matches/landmark-unique-matches.js

lib/checks/landmarks/landmark-is-unique.json

lib/checks/landmarks/landmark-is-unique-after.js

Resolved

jeankaplansky · 2019-06-17T16:11:58Z

Rule help for 3.3 required.

waabid and others added 11 commits April 4, 2018 14:54

Merge pull request #1 from dequelabs/develop

4a8beea

Merge from deque/axe-core

Merge branch 'develop' of https://github.com/dequelabs/axe-core into …

c906f06

…develop

Initial attempt at landmark-unique rule

b6d1986

Adding matches tests WIP

d490bf0

Re-factored and added tests for matches function

560b9f8

Merge branch 'develop' of https://github.com/dequelabs/axe-core into …

6fe36e7

…users/waabid/uniqueLandmarks2

Added support for virtual nodes

016466b

Using findUp api instead of looking up the tree ourselves

3fe93c3

Migrated unique-ness logic to after and removed code

6cebced

Added tests for landmark-is-unique-after

06900ad

Added best practice tag to unique landmark rule

bfce046

waabid requested a review from a team as a code owner February 28, 2019 01:01

waabid and others added 2 commits February 28, 2019 15:06

Added test for form elements

e29a2fc

Merge branch 'develop' into users/waabid/uniqueLandmarks2

0ff7e4c

dylanb requested changes Mar 1, 2019

View reviewed changes

waabid added 8 commits March 1, 2019 13:17

Added comment to explain filtering in landmark matches function

92a9afe

Merge branch 'users/waabid/uniqueLandmarks2' of https://github.com/wa…

8a9dcb0

…abid/axe-core into users/waabid/uniqueLandmarks2

Changed usage of actual node with virtual node where possible in land…

20fd686

…mark-unique-matches

Use related nodes api instead of failing duplicate landmarks

da1a124

Updated landmark is unique check test to validate related nodes

7e6c652

Added a failing iframe test for landmark-unique

de967e0

Added a test case for matching landmark-unique against elements in sh…

94dc1f1

…adow dom

Implement own findIndex for landmark-is-unique to unblock tests

536366d

jeeyyy previously requested changes Mar 2, 2019

View reviewed changes

dylanb reviewed Mar 4, 2019

View reviewed changes

test/integration/rules/landmark-unique/frame.html Show resolved Hide resolved

dylanb previously requested changes Mar 4, 2019

View reviewed changes

test/rule-matches/landmark-unique-matches.js Outdated Show resolved Hide resolved

lib/rules/landmark-unique-matches.js Show resolved Hide resolved

waabid added 3 commits March 4, 2019 17:34

Used find instead of findIndex (from polyfills)

0dec669

Updated the landmark-unique-matches to use the virtual node by default

ef8a005

Updated nodeName usage to upper case

526b48c

waabid added 5 commits April 4, 2019 17:17

Updated text for new rule

efa4d52

One last const to var

a45253f

Merge https://github.com/dequelabs/axe-core into users/waabid/uniqueL…

acd6720

…andmarks2

Updated to remove all const/let uses

ea8f641

Use accessibletextvirtual

4dfc817

WilcoFiers self-requested a review April 16, 2019 16:45

waabid added 2 commits April 18, 2019 11:44

Fixed test by passing virtual node in to landmark is unique

dd8b5cc

Merge https://github.com/dequelabs/axe-core into users/waabid/uniqueL…

cc0a4b9

…andmarks2

WilcoFiers added this to the Axe-core 3.3 milestone Apr 23, 2019

WilcoFiers removed this from the Axe-core 3.3 milestone May 17, 2019

WilcoFiers closed this May 17, 2019

WilcoFiers reopened this May 17, 2019

straker added 3 commits May 23, 2019 14:27

Merge remote-tracking branch 'upstream/develop' into users/waabid/uni…

85d3240

…queLandmarks2

sync upstream/develop

9e1f8ec

remove es6 syntax from tests

3b3580a

straker self-assigned this May 24, 2019

WilcoFiers previously requested changes Jun 3, 2019

View reviewed changes

straker added 2 commits June 4, 2019 14:44

cleanup

aafa4a1

fix typo

e64d406

WilcoFiers approved these changes Jun 5, 2019

View reviewed changes

straker merged commit 0088e94 into dequelabs:develop Jun 5, 2019

jeankaplansky mentioned this pull request Jun 17, 2019

landmark-unique-name #866

Closed

jeankaplansky self-assigned this Jun 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rule): Adding landmark-is-unique rule #1394

feat(rule): Adding landmark-is-unique rule #1394

waabid commented Feb 28, 2019 •

edited by WilcoFiers

Loading

CLAassistant commented Feb 28, 2019 •

edited

Loading

dylanb left a comment •

edited

Loading

jeeyyy left a comment

dylanb commented Apr 12, 2019

waabid commented Apr 18, 2019

WilcoFiers commented May 17, 2019

WilcoFiers commented May 17, 2019

WilcoFiers left a comment

jeankaplansky commented Jun 17, 2019

feat(rule): Adding landmark-is-unique rule #1394

feat(rule): Adding landmark-is-unique rule #1394

Conversation

waabid commented Feb 28, 2019 • edited by WilcoFiers Loading

Reviewer checks

CLAassistant commented Feb 28, 2019 • edited Loading

dylanb left a comment • edited Loading

Choose a reason for hiding this comment

jeeyyy left a comment

Choose a reason for hiding this comment

dylanb commented Apr 12, 2019

waabid commented Apr 18, 2019

WilcoFiers commented May 17, 2019

WilcoFiers commented May 17, 2019

WilcoFiers left a comment

Choose a reason for hiding this comment

jeankaplansky commented Jun 17, 2019

waabid commented Feb 28, 2019 •

edited by WilcoFiers

Loading

CLAassistant commented Feb 28, 2019 •

edited

Loading

dylanb left a comment •

edited

Loading