Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aria-roledescription): deprecate and disable rule #3948

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Mar 20, 2023

After testing, the aria-roledescription attribute seems to be fully supported* in the various browsers / screen readers. We can remove this rule now, so will do so in the next major release.

Closes: #3649

  • There are a few inconsistencies between browsers, but not enough to keep the rule.

@straker straker requested a review from a team as a code owner March 20, 2023 20:59
@straker straker merged commit 1913a9e into develop Mar 22, 2023
@straker straker deleted the deprecated-roledescription branch March 22, 2023 20:43
@kensgists
Copy link

@straker Is another axe rule already testing for valid usage of aria-roledescription? aria-allowed-attr maybe?

@straker
Copy link
Contributor Author

straker commented Mar 24, 2023

@kensgists We currently do not have another rule that tests if aria-roledescription is used correctly. #3955 is set up to track validating usage of ARIA roledescription and braille attrs.

@kensgists
Copy link

@straker Appreciate the information. Will track the progress of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positives when using aria-roledescription
3 participants