fix(color-contrast): correctly determine color contrast for element that exactly overlaps midpoint of node #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…element that exactly overlaps midpoint of node
straker
changed the title
WilcoFiers
previously requested changes
Aug 9, 2022
Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Wilco Fiers <[email protected]>
…labs/axe-core into color-contrast-float-equal
WilcoFiers
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/dequelabs/axe-core/pull/2003/files we changed the algorithm from
<to<=to handle nodes returning as incomplete in the code highlighting. The tests added fortest/integration/full/contrast/code-highlighting.htmlassert that only 1 incomplete is returned, so this change does not affect the reason we moved from<to<=in the first place.Closes issue: #3563