fix(respondable): avoid crashes if the data in window.postMessage is null
#3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
straker
previously requested changes
Nov 4, 2021
There was a problem hiding this comment.
Thanks for the pr. Could you add a test for this case in the respondable test? Probably after the repeater test
axe-core crashes if another process sends a `window.postMessage` with data equals to `null`. In the previous version, because `null` has a type of `'object'`, it crashed when trying to access the `channelId` on `null`.
esanzgar
force-pushed
the
postMessag-null
branch
from
8bc1ef4
to
3a266e1
Compare
|
I added the test. I am not very familiar with the internals with axe-core, so I am afraid you will need to take it from there. |
WilcoFiers
approved these changes
Nov 11, 2021
|
Reviewed for security |
straker
changed the title
window.postMessage is nullwindow.postMessage is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axe-core crashes if another process sends a
window.postMessagewithdata equals to
null.In the previous version, because
nullhas a type of'object', itcrashed when trying to access the
channelId.This change detects first if the data is not
null.