-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(required-parent): Allow *item > group > *item nesting #2898
Conversation
bed8b5e
to
1990875
Compare
1990875
to
2996146
Compare
try { | ||
var test = JSON.parse(content); | ||
} catch (e) { | ||
throw new Error('Unable to parse content of ' + file.originalPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encountered this because I had a stray comma. Figured I'd tweak it a bit.
@@ -107,6 +108,29 @@ All checks allow these global options: | |||
</tbody> | |||
</table> | |||
|
|||
### aria-required-parent | |||
|
|||
<table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NBD but it's strange that we're not using Markdown to generate this table 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember it was because Markdown table syntax wasn't working so well with multiline code blocks in the cells.
* fix(required-parent): Allow *item > group > *item nesting * chore(required-parent): Exclude menuitem from exception * chore(required-parent): Add ownGroupRoles option
Related to #2897.
Need to look into menuitem before we merge this.
menuitem > group > menuitem
doesn't work nearly as well as treeitem and listitem seem to.