Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(respondable): work on iframes in shadow DOM #2857

Merged
merged 1 commit into from
Apr 1, 2021
Merged

fix(respondable): work on iframes in shadow DOM #2857

merged 1 commit into from
Apr 1, 2021

Conversation

WilcoFiers
Copy link
Contributor

Instead of checking window.frames, check frame.parent. Checked the HTML specs, apparently the spec authors thought this makes sense: WICG/webcomponents#145

Closes issue: #2835

@WilcoFiers WilcoFiers requested a review from a team as a code owner March 31, 2021 13:30
straker
straker approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with the help of the extension team and it looks like it's passing the gauntlet iframe test file. The original ticket that this closes no longer seems to throw the error so we weren't able to test it there.

@WilcoFiers WilcoFiers merged commit 38cad94 into develop Apr 1, 2021
@WilcoFiers WilcoFiers deleted the respondable-iframes branch April 1, 2021 08:41
straker pushed a commit that referenced this pull request Apr 1, 2021
@WilcoFiers @straker
fix(respondable): work on iframes in shadow DOM (#2857)
65cbfd0
@WilcoFiers WilcoFiers mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilcoFiers @straker