Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aria/get-roles-by-type): deprecate in favor of standards/get-aria-roles-by-type #2362

Merged
merged 4 commits into from
Jul 13, 2020
Merged

feat(aria/get-roles-by-type): deprecate in favor of standards/get-aria-roles-by-type #2362

merged 4 commits into from
Jul 13, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 10, 2020 •
edited by WilcoFiers
Loading

We should probably have a discussion about what commons/aria functions should be moved into the standards helpers.

Part of #2108

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 10, 2020 16:39
WilcoFiers
WilcoFiers previously approved these changes Jul 13, 2020
View reviewed changes
@straker straker merged commit c0c37ea into develop Jul 13, 2020
@straker straker deleted the get-roles-by-type branch July 13, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers