fix(respondable): ignore reflected messages from iframes #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code wasn't ignoring errant iframes from responding to our post messages with data we weren't expecting or to reflected messages. So to ensure we ignored these messages I assigned a unique id to each axe instance. When we receive a message we look to make sure the messages came from a different axe instance than the one listening to the event. That way we are guaranteed to only respond to messages sent from an axe instance inside an iframe.
Closes issue: #2127
Reviewer checks
Required fields, to be filled out by PR reviewer(s)