Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(matches-selector): don't call matches function if none exist on the element #1613

Merged
merged 2 commits into from
Jun 6, 2019
Merged

fix(matches-selector): don't call matches function if none exist on the element #1613

merged 2 commits into from
Jun 6, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 5, 2019 •
edited by stephenmathieson
Loading

When passing no context to axe.run, the <html> element would try to find-up and get the document node as the parent, which doesn't have any matches function and so would error in element-matches.js when calling node[method](selector).

Linked issue: #1585

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: stephen

@straker straker requested a review from a team as a code owner June 5, 2019 17:22
@WilcoFiers WilcoFiers added this to the Axe-core 3.3 milestone Jun 5, 2019
@straker straker changed the title fix(find-up): fix IE11 to not pass document element to matchesSelector fix(matches-selector): don't call matches function if none exist on the element Jun 5, 2019
@straker straker merged commit 7581592 into develop Jun 6, 2019
@straker straker deleted the fixIE11ColorContrast branch June 6, 2019 14:45
AutoSponge pushed a commit that referenced this pull request Jun 6, 2019
@straker @AutoSponge
fix(matches-selector): don't call matches function if none exist on t…
bd5873b 
…he element (#1613)

* fix(find-up): fix IE11 to not pass document element to matchesSelector

* fix test
AutoSponge pushed a commit that referenced this pull request Jun 6, 2019
@straker @AutoSponge
fix(matches-selector): don't call matches function if none exist on t…
a470b91 
…he element (#1613)

* fix(find-up): fix IE11 to not pass document element to matchesSelector

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@straker @stephenmathieson @WilcoFiers