From 7989f42f866699b726f596add387fb19fa39bc55 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 6 Mar 2014 05:11:07 +0100 Subject: [PATCH] build: fix g++ 4.8 build, disable -Werror Turn off -Werror when building V8, it hits -Werror=unused-local-typedefs with g++ 4.8. The warning itself is harmless so don't abort the build. This was originally implemented in commit d2ab314e back in 2011 but the build process has gone through a few iterations since then, that change no longer works. --- common.gypi | 1 + node.gyp | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/common.gypi b/common.gypi index 4193b5ab6bfe97..8adafe39360fec 100644 --- a/common.gypi +++ b/common.gypi @@ -1,5 +1,6 @@ { 'variables': { + 'werror': '', # Turn off -Werror in V8 build. 'visibility%': 'hidden', # V8's visibility setting 'target_arch%': 'ia32', # set v8's target architecture 'host_arch%': 'ia32', # set v8's host architecture diff --git a/node.gyp b/node.gyp index c24c230b650fb6..f6586c4d44d68d 100644 --- a/node.gyp +++ b/node.gyp @@ -1,9 +1,6 @@ { 'variables': { 'v8_use_snapshot%': 'true', - # Turn off -Werror in V8 - # See http://codereview.chromium.org/8159015 - 'werror': '', 'node_use_dtrace%': 'false', 'node_use_etw%': 'false', 'node_use_perfctr%': 'false',