Fixes #177, --packages and --excludePackages filtering #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filtering logic for both `--packages` and `--excludePackages` was broken if the output was being colorized. To work around this I have moved the colorization out of the parsing logic and into the formatting. This change means we no longer need to use `strip-colors` so I've removed this as a dependency.
jonny-improbable
commented
Oct 9, 2018
|
|
||
| if (shouldColorizeOutput(args)) { | ||
| var keys = Object.keys(json); | ||
| keys.forEach(function(key) { |
There was a problem hiding this comment.
This is a little bit ugly; tbh the colorisation of the key should be performed inside the formatter, however this is a pragmatic fix if you're OK with it for now :)
jonny-improbable
commented
Oct 9, 2018
| @@ -35,12 +34,6 @@ var flatten = function(options) { | |||
| readmeFile, | |||
| licenseData, dirFiles, files = [], noticeFiles = [], licenseFile; | |||
|
|
|||
| /*istanbul ignore next*/ | |||
| if (colorize) { | |||
| moduleInfo = { licenses: chalk.bold.red(UNKNOWN) }; | |||
There was a problem hiding this comment.
initialising the license had nothing to do with colorising.
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering logic for both
--packagesand--excludePackageswas broken if the output was being colorized.To work around this I have moved the colorization out of the parsing logic and into the formatting.
WRT to removing
strip-ansi, I'm not convinced this package was actually being imported anywhere before this change, but I couldn't find it referenced anywhere in the code so I've removed it for good hygine.