Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs to reflect daneden/Toast@dacab2e #34

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Updated docs to reflect daneden/Toast@dacab2e #34

merged 1 commit into from
Jul 10, 2015

Conversation

ofagbemi
Copy link
Contributor

@ofagbemi ofagbemi commented Jul 2, 2015

Just updated the variable names in the doc comments.

While I'm at it, do you think it'd make sense to name the variables something more closely related to the name of the library? Like maybe $toast-grid-namespace, etc?

@ofagbemi ofagbemi changed the title Updated docs to reflect daneden/Toast@dacab2e Updated docs to reflect #dacab2e Jul 2, 2015
@ofagbemi ofagbemi changed the title Updated docs to reflect #dacab2e Updated docs to reflect daneden/Toast@dacab2e Jul 2, 2015
@daneden
Copy link
Owner

daneden commented Jul 9, 2015

@ofagbemi if you wouldn’t mind updating the variables to $toast-whatever in this PR, that’d be great! :)

@ofagbemi
Copy link
Contributor Author

ofagbemi commented Jul 9, 2015

Updated and squashed 👍

daneden added a commit that referenced this pull request Jul 10, 2015
@daneden daneden merged commit 6328ea9 into daneden:master Jul 10, 2015
@daneden
Copy link
Owner

daneden commented Jul 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants