Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce image sizes #83

Closed
wants to merge 1 commit into from
Closed

Reduce image sizes #83

wants to merge 1 commit into from

Conversation

cleishm
Copy link

@cleishm cleishm commented Jan 29, 2019

Suggesting a few changes that should reduce the image sizes, by not installing "recommended" dependencies (only required ones) and ensuring the apt-get package lists are consistently purged.

Is a test suite available for these images?

Only install required dependencies and ensure apt package lists are purged
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

@schliflo schliflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable 👍

@bahmutov
Copy link
Contributor

bahmutov commented Apr 4, 2019

how much space are these changes save?

@cleishm
Copy link
Author

cleishm commented Apr 5, 2019

how much space are these changes save?

As an example, for thebase/10 image the size drops from 1.09GB to 928MB. The adjustments are based on the recommended best practices, and checked with a dockerfile linter.

@bahmutov
Copy link
Contributor

bahmutov commented Apr 7, 2019

hi @cleishm thank you for showing how to reduce image size, I did not know about this. While we do not plan to replace existing Node images to avoid problems, I promise that going forward we will be building reduced images. For example I built #98 like this.

I will close your pull request for now though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants