e2e tests aren't checking transaction execution code to determine successful result

[colin-axner]

Summary

While working on governance proposal submission tests I realized it was possible to have a failed transaction which returned no error. So:

txResp, err := s.BroadcastMessages(msg) // message fails
s.Require().NoError(err) // this check pass
s.Require().AssertValidTxResponse(txResp) // fails on empty events

The message is broadcasted but errors in the state machine so the transaction code != 0. Our code isn't really explicitly checking this.

Proposal

Change AssertValidTxResponse to AssertSuccessfulTx (or AssertTxSuccess). Add a line to the function

s.Require().Equal(0, txResp.Code)

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[crodriguezvega]

Proposed change has been implemented in #3475.