Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator Creation Updates #3789

Closed
2 of 4 tasks
alexanderbez opened this issue Mar 3, 2019 · 5 comments · Fixed by #3803
Closed
2 of 4 tasks

Validator Creation Updates #3789

alexanderbez opened this issue Mar 3, 2019 · 5 comments · Fixed by #3803

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Mar 3, 2019

Summary

Brain dump from conversations with @jaekwon @sunnya97 and @rigelrozanski with regards to allowing new (non-genesis) validators to be created while still allowing them to unjail and immediately unbond (under the assumption that "normal" transfers are disabled):

  • Remove NewMsgCreateValidatorOnBehalfOf and any related logic
  • Ensure that the operator address equals the delegator address in MsgCreateValidator#ValidateBasic
  • Ensure the bond amount meets the self-delegation minimum MsgCreateValidator#ValidateBasic (already exists)
  • Unit/integration tests

Needs further discussion:

  • Ensure you cannot edit a validator if self-delegation is below minimum

Note: This assumes the validator can transfer some amount of uatoms to the new account in order to self-bond.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jackzampolin
Copy link
Member

Is this being implemented in #3787

@alexanderbez
Copy link
Contributor Author

No this is separate :)

@cwgoes
Copy link
Contributor

cwgoes commented Mar 4, 2019

It doesn't seem problematic, but why prevent editing validators with below-minimum self-delegation?

@alexanderbez
Copy link
Contributor Author

@cwgoes -- something @jaekwon recommended. I can't see any immediate good reason for doing so either.

@ice-cronus
Copy link

Hello @alexanderbez! May be you still remember, why equality of delegator and validator address is required by business logic? We're looking for some scenario that another account is responsible to pay self-delegation fee for validator address, any possible side effects if we are disable that check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants