Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: remove BlockHeight in context #4580

Merged
merged 4 commits into from
Jun 18, 2019
Merged

R4R: remove BlockHeight in context #4580

merged 4 commits into from
Jun 18, 2019

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jun 18, 2019

closes #4578

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #4580 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4580      +/-   ##
==========================================
+ Coverage   52.61%   52.65%   +0.04%     
==========================================
  Files         263      263              
  Lines       16464    16463       -1     
==========================================
+ Hits         8662     8669       +7     
+ Misses       7154     7146       -8     
  Partials      648      648

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good - I'd test the BlockHeight() return value after a WithBlockHeight() call

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks @colin-axner. Can we add a quick unit test in context_test.go?

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio alessio merged commit 84a2582 into cosmos:master Jun 18, 2019
@gitcoinbot gitcoinbot mentioned this pull request Jun 20, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Context.BlockHeight
3 participants