Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/stake -> x/staking #2222

Closed
rigelrozanski opened this issue Sep 3, 2018 · 5 comments · Fixed by #3280
Closed

x/stake -> x/staking #2222

rigelrozanski opened this issue Sep 3, 2018 · 5 comments · Fixed by #3280

Comments

@rigelrozanski
Copy link
Contributor

this was only ever renamed "stake" in order to differentiate between it and the "simple-staking" which is long gone from the core modules folder. so let's name back!

@cwgoes
Copy link
Contributor

cwgoes commented Sep 8, 2018

Eh, do we rename x/bank to x/banking then? I think x/stake is OK. No strong opinion though.

@rigelrozanski
Copy link
Contributor Author

rigelrozanski commented Sep 9, 2018

fair - how about renaming slashing to slash to just stay consistent then? I think I'm good with either that change or my original proposed change

@cwgoes
Copy link
Contributor

cwgoes commented Sep 9, 2018

Fair! Actually I like the combo of x/banking, x/staking, and x/slashing - verbs seem more common than nouns ("bank" happens to be a standard English noun which makes sense in this context, but neither "stake" nor "slash" are).

cc @jbibla thoughts?

@ValarDragon
Copy link
Contributor

ValarDragon commented Sep 9, 2018

I think leaving bank as is is fine, though I agree for changing staking. There are a lot of modules people will want to build that can only be properly named via a noun, not a verb I feel. E.g. micropaying is a weird name imo whereas micropayments sounds way better. (There's also no verb for IBC)

@jbibla
Copy link
Contributor

jbibla commented Jan 22, 2019

sorry @cwgoes - i didn't see this until today somehow. i like your suggestion. verbs and consistency FTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants