Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include DelayedJob errors in Errbit exceptions #4693

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Include DelayedJob errors in Errbit exceptions #4693

merged 1 commit into from
Oct 11, 2021

Conversation

javierm
Copy link
Member

@javierm javierm commented Sep 5, 2021

References

Background

The integration between Airbrake/Errbit and DelayedJob wasn't working because we require our dependencies in alphabetic order, and so by the time airbrake was required, delayed_job wasn't loaded.

Objectives

  • Make sure CONSUL installations using Airbrake/Errbit are notified when a delayed job fails

@javierm javierm self-assigned this Sep 5, 2021
@javierm javierm force-pushed the delayed_errbit branch 3 times, most recently from 24170e1 to 0a61305 Compare October 7, 2021 23:11
@javierm
Include DelayedJob errors in Errbit exceptions
9f21c27 
The integration between Airbrake/Errbit and DelayedJob wasn't working
because we require our dependencies in alphabetic order, and so by the
time `airbrake` was required, `delayed_job` wasn't loaded.

So we're manually requiring the integration.
@taitus taitus self-assigned this Oct 11, 2021
@javierm javierm merged commit 1a54659 into master Oct 11, 2021
@javierm javierm deleted the delayed_errbit branch October 11, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taitus taitus taitus approved these changes

Assignees

@taitus taitus

@javierm javierm

Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javierm @taitus