Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web sections to seeds #3037

Merged

Conversation

PierreMesure
Copy link
Collaborator

References

Add references to related Issues/Pull Requests/Travis Builds/Rollbar errors/etc...

Objectives

Add web sections in the normal seeds so users can create banners and enable them on some sections

Visual Changes

Before

capture d ecran 2018-11-13 a 17 39 04

After

capture d ecran 2018-11-13 a 17 41 32

Notes

  • This is just updating the seeds, not any code of the app.
  • Those who want the same result without re-running the seeds can just run rake web_sections:generate.

@voodoorai2000
Copy link
Member

Thank you very much @PierreMesure 😊👏

Just a couple of details:
Would you mind rebasing into a single commit?
And moving the code to the end of the file? We are planning on separating settings from other seed data 😌

@PierreMesure PierreMesure reopened this Dec 7, 2018
@PierreMesure
Copy link
Collaborator Author

Done @voodoorai2000! Have a nice weekend!

@voodoorai2000
Copy link
Member

Fantastic, thank you @PierreMesure! 🎉

@voodoorai2000 voodoorai2000 merged commit 74f7be5 into consuldemocracy:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants