Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: React Styleguidist template #1265

Merged
merged 2 commits into from
Dec 15, 2018
Merged

WIP: React Styleguidist template #1265

merged 2 commits into from
Dec 15, 2018

Conversation

sapegin
Copy link
Contributor

@sapegin sapegin commented Nov 2, 2018

Feature: React Styleguidist server template.

Checklist:

  • Importer
  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Looks like I'm missing something obvious here, but it doesn't want to pick up the right template. It also opens CNAME file by default.

image 2018-11-02 at 4 15 06 pm

image 2018-11-02 at 4 13 09 pm

(Logo needs some tweaking too ;-)

@sapegin
Copy link
Contributor Author

sapegin commented Nov 12, 2018

@CompuIves Any chance you can help me here? 🙏

@CompuIves
Copy link
Member

Ahh, sorry for the late response here! I just took a look and the PR looks great, I want to do a bit more exploration on the "new sandbox" modal before merging this in. We are getting so many templates that I think we'll overwhelm the starters with all the options.

I should have something tomorrow!

@CompuIves
Copy link
Member

Merging in now, deploying tomorrow. Sorry for the delay!

@CompuIves CompuIves merged commit 567ad00 into codesandbox:master Dec 15, 2018
CompuIves pushed a commit to codesandbox/codesandbox-importers that referenced this pull request Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants