Default to AWS_DEFAULT_PROFILE for IAM assume-role #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Feb 20, 2019
If AWS_IAM_ROLE_INTERACTIVE is not set, we default to previous behaviour of using AWS_DEFAULT_PROFILE and not prompting via selector. Rather than removing our (CloudPosse) use of AWS_DEFAULT_PROFILE from the stage Dockerfiles, check for the presence of AWS_IAM_ROLE_INTERACTIVE var. AWS_DEFAULT_PROFILE is used in other places, so we don’t want to remove it. `assume-role` therefore has the following precedence: `assume-role $role` - assumes $role `assume-role` - with AWS_IAM_ROLE_INTERACTIVE set will prompt with a role selector `assume-role` - assumes AWS_DEFAULT_PROFILE
joshmyers
force-pushed
the
default_aws_profile
branch
from
879fe5b
to
72f130e
Compare
osterman
approved these changes
Feb 23, 2019
|
Thanks @joshmyers !! |
leb4r
pushed a commit
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Default to AWS_DEFAULT_PROFILE for IAM assume-role
why
If AWS_IAM_ROLE_INTERACTIVE is not set, we default to previous behaviour
of using AWS_DEFAULT_PROFILE and not prompting via selector. Rather
than removing our (CloudPosse) use of AWS_DEFAULT_PROFILE from the stage
Dockerfiles, check for the presence of AWS_IAM_ROLE_INTERACTIVE var. AWS_DEFAULT_PROFILE is used in other places, so we don’t want to remove it.
assume-roletherefore has the following precedence:assume-role $role- assumes $roleassume-role- with AWS_IAM_ROLE_INTERACTIVE set will prompt with a role selectorassume-role- assumes $AWS_DEFAULT_PROFILE