-
Notifications
You must be signed in to change notification settings - Fork 1
/
batch_test.go
211 lines (185 loc) · 7.31 KB
/
batch_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
package services
import (
"context"
"encoding/json"
"sync"
"testing"
"time"
"github.com/google/uuid"
"github.com/ceramicnetwork/go-cas/common/loggers"
"github.com/ceramicnetwork/go-cas/models"
)
func TestBatch(t *testing.T) {
t.Setenv("ANCHOR_BATCH_SIZE", "3")
t.Setenv("ANCHOR_BATCH_LINGER", "5s")
requests := []*models.AnchorRequestMessage{
{Id: uuid.New()},
{Id: uuid.New()},
{Id: uuid.New()},
{Id: uuid.New()},
{Id: uuid.New()},
}
encodedRequests := make([]string, len(requests))
for i, request := range requests {
if requestMessage, err := json.Marshal(request); err != nil {
t.Fatalf("Failed to encode request %v", request)
} else {
encodedRequests[i] = string(requestMessage)
}
}
logger := loggers.NewTestLogger()
tests := map[string]struct {
publisher *MockPublisher
expectedNumberOfRequestsPerBatch []int
shouldError bool
encodedRequests []string
}{
"Can create batches after linger and when full": {
publisher: &MockPublisher{messages: make(chan any, 2)},
expectedNumberOfRequestsPerBatch: []int{3, 2},
shouldError: false,
encodedRequests: encodedRequests,
},
"Should return error if requests are malformed": {
publisher: &MockPublisher{messages: make(chan any, 2)},
expectedNumberOfRequestsPerBatch: []int{},
shouldError: true,
encodedRequests: []string{"hello"},
},
"Should return error if cannot publish batch": {
publisher: &MockPublisher{messages: make(chan any, 2), errorOn: 1},
expectedNumberOfRequestsPerBatch: []int{},
shouldError: true,
encodedRequests: encodedRequests[:3],
},
}
testCtx := context.Background()
for name, test := range tests {
t.Run(name, func(t *testing.T) {
metricService := &MockMetricService{}
s3BatchStore := &MockS3BatchStore{}
batchingServices := NewBatchingService(testCtx, test.publisher, s3BatchStore, metricService, logger)
ctx, cancel := context.WithCancel(testCtx)
var wg sync.WaitGroup
for _, er := range test.encodedRequests {
// 5 request are batched simultaneously via go routines
// 1 batch is created with 3 requests (the anchor batch size is 3)
// after 5 seconds (the anchor batch linger is 5s) the 2nd batch is created containing 2 requests
// if errors occur no batches are created and errors are returned
encodedRequest := er
wg.Add(1)
go func() {
defer wg.Done()
err := batchingServices.Batch(ctx, encodedRequest)
if err != nil && !test.shouldError {
t.Errorf("Unexpected error received %v", err)
} else if err == nil && test.shouldError {
t.Errorf("Should have received error")
}
}()
}
if test.shouldError {
// if an error occurs no batch messages should have been sent
wg.Wait()
cancel()
if len(test.publisher.messages) != 0 {
t.Errorf("Received %v messages but should have received none", len(test.publisher.messages))
}
Assert(t, 0, metricService.counts[models.MetricName_BatchCreated], "Incorrect created batch count")
} else {
// with 5 requests 2 batches should have been created
receivedMessages := waitForMesssages(test.publisher.messages, 2)
wg.Wait()
cancel()
// decode the messages
receivedBatches := make([]models.AnchorBatchMessage, len(receivedMessages))
for i, message := range receivedMessages {
if batch, ok := message.(models.AnchorBatchMessage); !ok {
t.Fatalf("Received invalid anchor batch message: %v", message)
} else {
receivedBatches[i] = batch
}
}
// make sure the batches have the correct number of requests in them, cannot ensure which request are in which batch
// as the batch requests are made simultaneously
numIngressRequests := 0
for i, numRequestsInBatch := range test.expectedNumberOfRequestsPerBatch {
if s3BatchStore.getBatchSize(receivedBatches[i].Id.String()) != numRequestsInBatch {
t.Errorf("Expected %v requests in batch %v. Contained %v requests", numRequestsInBatch, i+1, len(receivedBatches[i].Ids))
}
numIngressRequests += numRequestsInBatch
}
Assert(t, numIngressRequests, metricService.counts[models.MetricName_BatchIngressRequest], "Incorrect batch ingress request count")
Assert(t, 2, metricService.counts[models.MetricName_BatchCreated], "Incorrect created batch count")
Assert(t, 2, metricService.counts[models.MetricName_BatchStored], "Incorrect stored batch count")
}
})
}
}
func TestHourlyBatch(t *testing.T) {
t.Setenv("ANCHOR_BATCH_SIZE", "100") // High value so we know the batch is not flushed due to size
t.Setenv("ANCHOR_BATCH_LINGER", "1h") // High value so we know the batch is not flushed due to linger
t.Setenv("ANCHOR_BATCH_FLUSH_INTERVAL", "1s")
requests := []*models.AnchorRequestMessage{
{Id: uuid.New()},
{Id: uuid.New()},
{Id: uuid.New()},
{Id: uuid.New()},
{Id: uuid.New()},
{Id: uuid.New()},
}
numRequests := len(requests)
encodedRequests := make([]string, len(requests))
for i, request := range requests {
if requestMessage, err := json.Marshal(request); err != nil {
t.Fatalf("Failed to encode request %v", request)
} else {
encodedRequests[i] = string(requestMessage)
}
}
logger := loggers.NewTestLogger()
testCtx := context.Background()
t.Run("flush batch at tick", func(t *testing.T) {
metricService := &MockMetricService{}
s3BatchStore := &MockS3BatchStore{}
publisher := &MockPublisher{messages: make(chan any, numRequests)}
ctx, cancel := context.WithCancel(testCtx)
batchingServices := NewBatchingService(testCtx, publisher, s3BatchStore, metricService, logger)
var wg sync.WaitGroup
for i := 1; i <= len(encodedRequests); i++ {
wg.Add(1)
go func() {
defer wg.Done()
if err := batchingServices.Batch(ctx, encodedRequests[i-1]); err != nil {
t.Errorf("Unexpected error received %v", err)
}
}()
// The flush interval is 1s so sleep for 2 seconds after every 2 requests to ensure the batch is flushed and
// contains 2 requests.
if i%2 == 0 {
<-time.After(2 * time.Second)
}
}
wg.Wait()
// Each batch should have 2 requests in it, so the number of batches should be half the number of requests.
receivedMessages := waitForMesssages(publisher.messages, numRequests/2)
cancel()
receivedBatches := make([]models.AnchorBatchMessage, len(receivedMessages))
for i, message := range receivedMessages {
if batch, ok := message.(models.AnchorBatchMessage); !ok {
t.Fatalf("Received invalid anchor batch message: %v", message)
} else {
receivedBatches[i] = batch
}
}
// Make sure each batch has 2 requests in it
for i := 0; i < len(receivedBatches); i++ {
if s3BatchStore.getBatchSize(receivedBatches[i].Id.String()) != 2 {
t.Errorf("Expected %v requests in batch %v. Contained %v requests", 2, i+1, len(receivedBatches[i].Ids))
}
}
Assert(t, numRequests, metricService.counts[models.MetricName_BatchIngressRequest], "Incorrect batch ingress request count")
Assert(t, numRequests/2, metricService.counts[models.MetricName_BatchCreated], "Incorrect created batch count")
Assert(t, numRequests/2, metricService.counts[models.MetricName_BatchStored], "Incorrect stored batch count")
})
}