Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TestAppKindChangeWithMetadataOutput to a separate file #604

Closed
100mik opened this issue Sep 13, 2022 · 2 comments · Fixed by #880
Closed

Move TestAppKindChangeWithMetadataOutput to a separate file #604

100mik opened this issue Sep 13, 2022 · 2 comments · Fixed by #880
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed good first issue An issue that will be a good candidate for a new contributor priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. snack This issue has been identified as lightweight and potentially quick to deliver.

Comments

@100mik
Copy link
Contributor

100mik commented Sep 13, 2022

Today TestAppKindChangeWithMetadataOutput resides in app_change_test.go.
However, it does not have anything to do with the app-change command group.

This should be moved to a separate file (maybe app_metadata_output_test.go)
@100mik 100mik added carvel triage This issue has not yet been reviewed for validity good first issue An issue that will be a good candidate for a new contributor carvel accepted This issue should be considered for future work and that the triage process has been completed priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. and removed carvel triage This issue has not yet been reviewed for validity labels Sep 13, 2022
@100mik
Copy link
Contributor Author

100mik commented Sep 13, 2022

A quick snack for someone looking to contribute!

@100mik 100mik added the snack This issue has been identified as lightweight and potentially quick to deliver. label Sep 13, 2022
@100mik 100mik mentioned this issue Sep 13, 2022
Merged
5 tasks
@EdwinWalela
Copy link

Is this still required? app_metadata_output_test.go doesn't seem to exist was it renamed?

@jignyasamishra jignyasamishra mentioned this issue Jan 14, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed good first issue An issue that will be a good candidate for a new contributor priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. snack This issue has been identified as lightweight and potentially quick to deliver.
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved TestAppKindChangeWithMetadataOutput to a separate file jignyasamishra/kapp
2 participants
@EdwinWalela @100mik