Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Cleanup npm package #325

Closed
wants to merge 1 commit into from

Conversation

yhnavein
Copy link

chore: remove unnecessary files from the npm package

This PR does not contain any change to the logic or the implementation. It is only reducing size of npm package by excluding files that are not necessary for a standard usage of this library.

Before: 25KB gzipped (138 KB and 102 files unpacked)
After: 9KB gzipped (39 KB and 15 files unpacked)

New tarball contents

Tarball Contents
----------------
1.1kB LICENSE
157B SECURITY.md
56B async.js
1.5kB bin/resolve
97B index.js
93B index.mjs
12.6kB lib/async.js
354B lib/caller.js
805B lib/homedir.js
1.3kB lib/node-modules-paths.js
348B lib/normalize-options.js
7.7kB lib/sync.js
2.3kB package.json
11.2kB readme.markdown
55B sync.js

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files field is dangerous and should never be used. Additionally, every one of these files are necessary.

@ljharb
Copy link
Member

ljharb commented Aug 17, 2024

Duplicate of #324. Duplicate of #308. Duplicate of #296. Duplicate of #281. Duplicate of #279. Duplicate of #239. Duplicate of #235. Duplicate of #58. Duplicate of #44. See #105 (comment).

@ljharb ljharb closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants