Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for Python 3.11 and 3.12 #481

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

thunderbiscuit
Copy link
Member

Just trying to see if it passes the test workflows...

Copy link

coderabbitai bot commented Mar 28, 2024

Warning

Rate Limit Exceeded

@thunderbiscuit has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 13 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between d066007 and c666bb2.

Walkthrough

The recent updates focus on modernizing the development environment and improving compatibility across the board. Key changes include updating Java and Kotlin versions to enhance JVM and Android builds, upgrading Gradle for better build tooling, and introducing Rust and Python updates for broader development support. Additionally, there's a significant focus on error handling improvements, particularly around fee rate calculations in the Bitcoin development kit, alongside structural changes to build and test configurations to streamline development processes.

Changes

Files Change Summary
.github/workflows/...,
bdk-android/README.md,
bdk-jvm/README.md
Updated Java version from 11 to 17, set Rust version to 1.73.0, added Python versions 3.11 and 3.12, updated Kotlin version requirement from 1.6.10 to 1.9.23, and JDK version from 11 to 17.
bdk-android/build.gradle.kts,
bdk-android/lib/build.gradle.kts,
bdk-jvm/build.gradle.kts,
bdk-jvm/lib/build.gradle.kts
Plugin declarations and versions updated, including changes in application settings, repository configurations, and build configurations.
bdk-android/gradle/wrapper/gradle-wrapper.properties,
bdk-jvm/gradle/wrapper/gradle-wrapper.properties
Updated Gradle distribution URL to newer versions (Android: 7.3.2 to 8.4, JVM: 7.3.2 to 8.7) with additional network timeout and URL validation settings for JVM.
bdk-android/justfile,
bdk-ffi/justfile,
bdk-jvm/justfile,
bdk-python/justfile,
bdk-swift/justfile
Introduced justfile in multiple projects for streamlined test, build, and local publishing tasks using respective build tools (Gradle, cargo, unittest).
bdk-android/settings.gradle.kts,
bdk-jvm/settings.gradle.kts,
bdk-ffi/src/...
Added plugin and dependency repositories for improved plugin management and dependency resolution, introduced FeeRateError for better error handling, modified fee rate calculations and error handling in the Bitcoin development kit.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@reez
Copy link
Collaborator

reez commented Apr 3, 2024

ACK

My only question is since the PR touches Python+JVM+Android (and I see this follow on PR about JVM+Android #480 ) I was wondering how you were going to approach the commit history? Since it would be nice to have the Python related ones in one PR and all the JVM+Android ones in the other PR (so like separate the PR's starting with the commit related to build: use jdk 17 for android and jvm builds)

@thunderbiscuit
Copy link
Member Author

Yes I had in mind of merging #480 first, then rebasing this one on top of it, which would then reduce this PR to only the dec1ca5 commit if I do my things correctly I think.

@reez
Copy link
Collaborator

reez commented Apr 3, 2024

Yes I had in mind of merging #480 first, then rebasing this one on top of it, which would then reduce this PR to only the dec1ca5 commit if I do my things correctly I think.

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants