Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-release fixes #478

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Mar 27, 2024

This PR does 3 things:

  • Add developer information for jvm, android, and python libraries.
  • Bump the development versions of bdk-android, bdk-jvm, and bdk-python.
  • Update the changelog
  • Update the release issue template.

On authors information: this was information that was removed as part of an old PR changing the authors. Complete removal actually breaks the bdk-jvm and bdk-android releases (example run here). It doesn't break the Python releases, but it's good to have it there anyway.

This error actually happened back with the alpha 2 release, but somehow I never cherry-picked that commit back onto master. This PR does that.

Copy link

coderabbitai bot commented Mar 27, 2024

Warning

Rate Limit Exceeded

@thunderbiscuit has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 31 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 9ea9e93 and 896303f.

Walkthrough

The recent updates involve enhancing the metadata of Bitcoin Dev Kit (BDK) language libraries by adding author information to the build scripts and setup configurations. These changes aim to provide clearer authorship details for the libraries.

Changes

File(s) Change Summary
bdk-android/gradle.properties,
bdk-jvm/gradle.properties
Updated libraryVersion in gradle.properties from 1.0.0-alpha.2b-SNAPSHOT to 1.0.0-alpha.8-SNAPSHOT.
bdk-python/setup.py Added Bitcoin Dev Kit Developers' email address to author information.
.github/workflows/publish-android.yaml Removed publishing to Maven Local, focused on publishing to Maven Central.
CHANGELOG.md Version 1.0.0-alpha.7: Reintroduced features from 0.31 release, added flat file persistence, detailed error handling.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, tests haven't finished running yet but I wanted to ACK 5fc30c6 because it looks good to me right now (and once the tests finish running and they pass then I'm good)

@thunderbiscuit thunderbiscuit changed the title Add developer information for jvm, android, and python libraries Post-release fixes Mar 27, 2024
@thunderbiscuit
Copy link
Member Author

Sorry @reez I actually decided to PR together a few different commits that all relate to post-release small fixes (instead of having 4 small PRs), so this is now growing in scope a bit.

@thunderbiscuit thunderbiscuit merged commit 896303f into bitcoindevkit:master Mar 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants