-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-release fixes #478
Post-release fixes #478
Conversation
Warning Rate Limit Exceeded@thunderbiscuit has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 31 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates involve enhancing the metadata of Bitcoin Dev Kit (BDK) language libraries by adding author information to the build scripts and setup configurations. These changes aim to provide clearer authorship details for the libraries. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, tests haven't finished running yet but I wanted to ACK 5fc30c6 because it looks good to me right now (and once the tests finish running and they pass then I'm good)
Sorry @reez I actually decided to PR together a few different commits that all relate to post-release small fixes (instead of having 4 small PRs), so this is now growing in scope a bit. |
This PR does 3 things:
On authors information: this was information that was removed as part of an old PR changing the authors. Complete removal actually breaks the bdk-jvm and bdk-android releases (example run here). It doesn't break the Python releases, but it's good to have it there anyway.
This error actually happened back with the alpha 2 release, but somehow I never cherry-picked that commit back onto master. This PR does that.