Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rename esplora scan to full_scan #442

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Jan 11, 2024

This should have been applied on the move to alpha 3. It renames the scan method on the Esplora client to full_scan, as per the latest esplora crate version (0.5.0).

Notes to the reviewers

Sorry I missed it on my last PR!

Changelog notice

Changed
  - The scan method on the Esplora client is renamed to full_scan [#442]

[#442]: https://github.com/bitcoindevkit/bdk-ffi/pull/442

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that bdk_file_store is needed for this PR from my review/testing from what I can tell, so maybe would remove bdk_file_store = { version = "0.3.0" } from Cargo.toml if possible. I know it's probably needed for #436 and will get added anyway, but nice to have it added in that PR instead of this PR based on the scope of the changes each PR.

But approving this either way, good work!

ACK f0a3217

@thunderbiscuit
Copy link
Member Author

Yes totally. I removed it. Will rebase my other PR.

@thunderbiscuit thunderbiscuit self-assigned this Jan 11, 2024
@thunderbiscuit thunderbiscuit merged commit 7319aea into bitcoindevkit:master Jan 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants