-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 10 to 13 fallback support #1
Comments
I have investigated on this a little bit and found a nice way to handle that (tell me if this works for you):
One (tiny) blocker: Another thing I see that using SVG will make it hard to respect the text baseline. With my regex to extract SVG, we totally lose the context. Maybe another solution would be more accurate to export the SVGs from a sliced template in Sketch ? |
@MoOx I have been doing a similar manual approach for my project right now. I think this would work, aside from the brand icons. Would you have to store all the svg files/converted RN SVGs in this project? Would that bloat the project too much? |
According to the license, we cannot store them in the repo, I guess in any form, if I interpreted the license correctly. |
Even without using actual SF symbols it would be nice to have a fallback option for when SF symbols is unavailable. Wix implements something similar: https://wix.github.io/react-native-navigation/api/options-imageResource/ |
Hi @birkir!
I am working on a react-native library to offer a consistent platform experience for icon.
This means in short: using sfsymbols on iOS when possible, and material icons for android.
I am open to help you to support iOS13- (even if I am not confortable with iOS development).
What work need to be done? If you lead me correctly I am sure I can handle some dirty work :)
The text was updated successfully, but these errors were encountered: