Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create single threaded Feature with scheduler #158

Merged
merged 15 commits into from
Aug 4, 2022
Merged

Create single threaded Feature with scheduler #158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2d3f03a
Copied BaseFeature as BaseAsyncFeature
LachlanMcKee Jul 15, 2022
b8cbe79
Reverted BaseFeature behaviour and removed BaseAsync nullability
LachlanMcKee Jul 15, 2022
0bc241b
Moved FeatureSchedulers into AsyncBaseFeature
LachlanMcKee Jul 15, 2022
8dbe512
Updated BaseFeature to automatically switch to provided feature sched…
LachlanMcKee Jul 16, 2022
88b4827
Created FeatureSchedulerFactory to allow creation of non-main thread …
LachlanMcKee Jul 18, 2022
8651cca
Updated MVICore demo to use featureScheduler
LachlanMcKee Jul 18, 2022
39baca8
Improved feature scheduler switching logic
LachlanMcKee Jul 22, 2022
cbdb442
Reintroduced disposables memory leak fix
LachlanMcKee Jul 22, 2022
b6eed1d
Added test to ensure BaseFeature is unit testable
LachlanMcKee Jul 22, 2022
b6817fa
Restructured FeatureSchedulers
LachlanMcKee Jul 22, 2022
a58c7b8
Renamed ActorReducerFeatureTestSchedulerTest
LachlanMcKee Aug 3, 2022
dcaef22
Removed unused mockito invocation
LachlanMcKee Aug 3, 2022
1cbb803
Minor codestyle improvements
LachlanMcKee Aug 3, 2022
53aa5f3
Removed onNext behaviour from observeOnFeatureScheduler
LachlanMcKee Aug 3, 2022
d241d13
Updated JavaDoc to explain featureScheduler behaviour
LachlanMcKee Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unused mockito invocation
  • Loading branch information
@LachlanMcKee
LachlanMcKee committed Aug 3, 2022
commit dcaef225fefe2e7a16ed0024f46d8416ed5e48d9
2 changes: 0 additions & 2 deletions mvicore/src/test/java/com/badoo/mvicore/feature/BaseFeatureWithSchedulerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import io.reactivex.schedulers.TestScheduler
import io.reactivex.subjects.PublishSubject
import org.junit.Before
import org.junit.Test
import org.mockito.MockitoAnnotations
import java.util.concurrent.CountDownLatch
import java.util.concurrent.TimeUnit
import kotlin.test.assertEquals
Expand All @@ -45,7 +44,6 @@ class BaseFeatureWithSchedulerTest {

@Before
fun prepare() {
MockitoAnnotations.initMocks(this)
SameThreadVerifier.isEnabled = true
LachlanMcKee marked this conversation as resolved.
Show resolved Hide resolved

newsSubject = PublishSubject.create<TestNews>()
Expand Down
2 changes: 0 additions & 2 deletions mvicore/src/test/java/com/badoo/mvicore/feature/BaseFeatureWithoutSchedulerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import io.reactivex.schedulers.TestScheduler
import io.reactivex.subjects.PublishSubject
import org.junit.Before
import org.junit.Test
import org.mockito.MockitoAnnotations
import java.util.concurrent.TimeUnit
import kotlin.test.assertEquals

Expand All @@ -38,7 +37,6 @@ class BaseFeatureWithoutSchedulerTest {

@Before
fun prepare() {
MockitoAnnotations.initMocks(this)
SameThreadVerifier.isEnabled = false

newsSubject = PublishSubject.create<TestNews>()
Expand Down