Create single threaded Feature with scheduler #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CherryPerry I don't suppose you would mind taking a look when you get a chance? :) |
CherryPerry
reviewed
Jul 22, 2022
LachlanMcKee
force-pushed
the
split-async-and-sync-base-feature
branch
3 times, most recently
from
fea2ce7
to
041beb8
Compare
LachlanMcKee
changed the title
LachlanMcKee
force-pushed
the
split-async-and-sync-base-feature
branch
from
041beb8
to
30f06d7
Compare
|
@CherryPerry I'm pretty happy with where the PR is now. I don't consider this a draft anymore |
CherryPerry
requested changes
Aug 3, 2022
mvicore/src/test/java/com/badoo/mvicore/feature/ActorReducerFeatureTestSchedulerTest.kt
Outdated
Show resolved
Hide resolved
mvicore/src/test/java/com/badoo/mvicore/feature/ActorReducerFeatureTestSchedulerTest.kt
Outdated
Show resolved
Hide resolved
mvicore/src/test/java/com/badoo/mvicore/feature/ActorReducerFeatureTestSchedulerTest.kt
Outdated
Show resolved
Hide resolved
mvicore/src/test/java/com/badoo/mvicore/feature/BaseFeatureWithSchedulerTest.kt
Outdated
Show resolved
Hide resolved
mvicore/src/test/java/com/badoo/mvicore/feature/BaseFeatureWithSchedulerTest.kt
Show resolved
Hide resolved
mvicore/src/test/java/com/badoo/mvicore/feature/BaseFeatureWithSchedulerTest.kt
Show resolved
Hide resolved
mvicore/src/test/java/com/badoo/mvicore/feature/BaseFeatureWithSchedulerTest.kt
Show resolved
Hide resolved
LachlanMcKee
force-pushed
the
split-async-and-sync-base-feature
branch
2 times, most recently
from
374d15e
to
dfa6fb9
Compare
CherryPerry
reviewed
Aug 3, 2022
LachlanMcKee
force-pushed
the
split-async-and-sync-base-feature
branch
from
dfa6fb9
to
c91156c
Compare
CherryPerry
approved these changes
Aug 3, 2022
LachlanMcKee
force-pushed
the
split-async-and-sync-base-feature
branch
from
c91156c
to
53aa5f3
Compare
zsoltk
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
Feedback greatly appreciated!