-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use full hierarchy for clients drawable #650
Comments
Something like: c:setup {
{
{
awful.titlebar(c, {args}).
c.widget,
{ --[[some bottom widget]] },
layout = wibox.layout.align.vertical
},
margins = 12,
widget = wibox.container.margins,
},
fg = "unicorn pink",
widget = wibox.container.background
} The current titlebar API could be implemented on top of that to keep the compatibility, then deprecate it for v5 (the current titlebar API is a mess) |
@Elv13 Is this something like what you have in mind? https://gist.github.com/psychon/ed4436cd5ad36da57c6dd81c69ac8e1c |
@Elv13 What would the In a wibox, the size of the wibox is given and the code "just" has to place widgets in there. So, any idea how the size of a titlebar is computed? And what would your |
With some love, it will do just fine, thanks a lot. I feel ashamed I didn't see the obvious earlier. I will work on it later. I am currently busy finishing a PR serie that stretch back to october (the improved doc)
Don't worry, I think with some work on the hierarchy handler, it can behave exactly like the titlebar currently does. |
I came up with this approach after our discussion yesterday. It wasn't so obvious to me either (and I needed way too long to get the "math" right for computing the positions of the individual titlebars). I understand your comment as you will handle this from here on and I should not continue working on this. Feel free to point out things that you want me to do here (so far I am still quite unsure how to get this nicely into |
If you wish to spend time on it, feel free to do so. Otherwise, yes, I will add it to my todo list.
I also failed to integrate the copy/paste from my dynamic |
Instead of hardcoding set_titlebar, I propose having a fully hierarchy for clients
Use case:
Complex border examples:
The text was updated successfully, but these errors were encountered: