fix(undo): undo after pair character input #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arkRedM
suggested changes
May 19, 2021
There was a problem hiding this comment.
Since you are already editing this fn
can you change https://github.com/athensresearch/athens/pull/1194/files#R572 to 575
to
(every? #(= % key lookbehind) ["}" ....]) ?
tangjeff0
changed the title
korlaism
pushed a commit
to korlaism/athens
that referenced
this pull request
Jul 19, 2021
* fix athensresearch#559: undo after pair character input * add comments: execCommand is obsolete * replace "or" clause with "some" to remove duplication Co-authored-by: jeff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #559.
The problem seems to be that the textarea value is set via
(set! (.-value target) new-value). This corresponds totarget.value = new-valuein JavaScript and seems to break the undo mechanism.In the above fix I replaced these commands by calls to
execCommand, as it is already the case in surround-and-set, which is called when the user presses cmd+y etc. to surround text with~~.