fix(contentarea): hide multiline text in contentarea #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fixed hidden multiline content taking up display space on hover
use reduced dimensions to hide contentarea instead of display: none; for improved performance
ozimos
force-pushed
the
fix/multiline-contentarea-1131
branch
from
f5ba241
to
45daba9
Compare
|
@shanberg review? explanation at #1131 (comment) Seems to fix the ghost hover effect, but then there is a flicker when blurring from the textarea: https://www.loom.com/share/8358b3c91f004b1ebca2c20574fbf3ad?focus_title=1&muted=1&from_recorder=1 |
shanberg
requested changes
May 18, 2021
tangjeff0
requested changes
May 19, 2021
remove flicker during textarea blur
ozimos
force-pushed
the
fix/multiline-contentarea-1131
branch
from
6bbf6a4
to
563fb7e
Compare
|
caret position in textarea fixed. Also fixed the flicker on textarea blur |
|
I'm impressed with your fixes here @ozimos. I'd sort of assumed we'd hit a local maximum with the textarea-based UX, but clearly it can still improve. Demo gifts attached. It’s maddening to see both animations together so I've linked them instead. |
shanberg
approved these changes
May 19, 2021
tangjeff0
approved these changes
May 19, 2021
korlaism
pushed a commit
to korlaism/athens
that referenced
this pull request
Jul 19, 2021
…1189) * fix: improve css for textarea when not editing fixed hidden multiline content taking up display space on hover * fix: remove display none on contentarea use reduced dimensions to hide contentarea instead of display: none; for improved performance * fix: clicking inserts caret in textarea remove flicker during textarea blur Co-authored-by: jeff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1131 by setting the default line-height on contentarea to 0.
close #613 (duplicate)