[preview9] Add non-owned table splitting support to query #17171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Aug 15, 2019
AndriySvyryd
force-pushed
the
TableSplitting
branch
from
50fd20b
to
7e12375
Compare
|
Updated. Now with uglier SQL. |
AndriySvyryd
force-pushed
the
TableSplitting
branch
from
7e12375
to
16118a0
Compare
|
FromSql will not work with table splitting unless the same query works without FromSql: #17215 |
smitpatel
reviewed
Aug 17, 2019
src/EFCore/Query/Internal/EntityEqualityRewritingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Aug 17, 2019
AndriySvyryd
force-pushed
the
TableSplitting
branch
from
16118a0
to
07e6609
Compare
|
@smitpatel Ping |
smitpatel
reviewed
Aug 19, 2019
smitpatel
reviewed
Aug 19, 2019
smitpatel
reviewed
Aug 19, 2019
AndriySvyryd
force-pushed
the
TableSplitting
branch
from
07e6609
to
9b540c2
Compare
AndriySvyryd
changed the title
|
@AndriySvyryd Why did you assign this to me? |
Materialize owned entities with all null properties if they are being referenced by other entities Fixes #16032
AndriySvyryd
force-pushed
the
TableSplitting
branch
from
9b540c2
to
932a973
Compare
|
@ajcvickers I don't have permissions to merge into preview9 |
|
@AndriySvyryd That should be fixed now. |
|
@ajcvickers Thanks. I thought it was by design. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Materialize owned entities with all null properties if they are being referenced by other entities
Fixes #16032