Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate terminate overloads in MigrationsSqlGenerator #16673

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Consolidate terminate overloads in MigrationsSqlGenerator #16673

merged 1 commit into from
Jul 20, 2019

Conversation

roji
Copy link
Member

@roji roji commented Jul 19, 2019

Closes #16654

@roji roji requested a review from bricelam July 19, 2019 20:06
@bricelam
Copy link
Contributor

I’m remembering it might be related to the work in bricelam:batch

bricelam
bricelam approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can’t think of a reason to keep both overloads

@roji roji merged commit 28fe450 into master Jul 20, 2019
@ghost ghost deleted the ConsolidateMigrationMethods branch July 20, 2019 10:57
@ajcvickers ajcvickers mentioned this pull request Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate overloads in MigrationsSqlGenerator
2 participants
@roji @bricelam