Back-out indexed Properties #16397
Merged
Back-out indexed Properties #16397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #16310 I looked at other options before doing this, but they all come back to making queries work or there is really no point. I also looked at leaving some of the code in, but that would basically resulting in maintaining dead code. So on balance, I'm opting for clean removal.
smitpatel
approved these changes
Jul 2, 2019
ghost
deleted the
divega
approved these changes
Jul 2, 2019
|
@divega I think we can just find this PR/commit |
|
@AndriySvyryd - Is the code in this PR good enough? I can start with a revert commit. |
|
@smitpatel Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16310
I looked at other options before doing this, but they all come back to making queries work or there is really no point. I also looked at leaving some of the code in, but that would basically resulting in maintaining dead code. So on balance, I'm opting for clean removal.