Add tests for FromSql with DbParameter without name prefix #16362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divega
commented
Jun 30, 2019
| protected override DbParameter CreateDbParameter(string name, object value) | ||
| => new SqliteParameter | ||
| { | ||
| ParameterName = name, | ||
| Value = value | ||
| }; | ||
|
|
||
| private void AssertSql(params string[] expected) |
There was a problem hiding this comment.
Noticed that so far we are not asserting SQL for other FromSql tests against SQLite. I can revert changes to this file if this is by design.
There was a problem hiding this comment.
We assert SQL in Sqlite provider when we expect it to differ from SQL server. Like different server side functions for date time operations.
There was a problem hiding this comment.
Sounds good. In this case there aren’t any differences, so I will remove for consistency.
divega
commented
Jun 30, 2019
test/EFCore.Relational.Specification.Tests/Query/FromSqlQueryTestBase.cs
Show resolved
Hide resolved
smitpatel
approved these changes
Jul 1, 2019
test/EFCore.Relational.Specification.Tests/Query/FromSqlQueryTestBase.cs
Show resolved
Hide resolved
| protected override DbParameter CreateDbParameter(string name, object value) | ||
| => new SqliteParameter | ||
| { | ||
| ParameterName = name, | ||
| Value = value | ||
| }; | ||
|
|
||
| private void AssertSql(params string[] expected) |
There was a problem hiding this comment.
We assert SQL in Sqlite provider when we expect it to differ from SQL server. Like different server side functions for date time operations.
ajcvickers
approved these changes
Jul 1, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New variations of FromSqlRaw and FromSqlInterpolated specification tests take DbParameter without using a prefix in the name. E.g. "city" instead of "@city" and verify that the prefix is added automatically when the parameter name is added in-line in the SQL.
Also added SQL Server
and SQLiteoverrides that assert the SQL.Closes #14173