Intercepters: Don't return null for Async methods #16348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using interceptor?. pattern sent null back for Task which was being awaited. Pattern, for async always make null check on interceptor before calling into. For Sync methods if they are returning void or possible null then only use interceptor?. Testing: Errors only happen when diagnosticSource enabled so that intercepter is null but we still go inside the block. Not sure how to set it up that in tests. Submitting PR to unblock ASP.NET Core
|
@AndriySvyryd - This is blocking ASP.NET Core dependency. Can you review? |
dougbu
reviewed
Jun 28, 2019
|
Please get this in ASAP and deal w/ my comments (if I'm correct) in a later cleanup PR |
AndriySvyryd
approved these changes
Jun 28, 2019
ghost
deleted the
roji
approved these changes
Jun 28, 2019
|
Ah, too late :) |
|
Thanks @smitpatel! I will add tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using interceptor?. pattern sent null back for Task which was being awaited.
Pattern, for async always make null check on interceptor before calling into.
For Sync methods if they are returning void or possible null then only use interceptor?.
Testing: Errors only happen when diagnosticSource enabled so that intercepter is null but we still go inside the block.
Not sure how to set it up that in tests. Submitting PR to unblock ASP.NET Core