Sqlite: Update northwind.db #16242
Merged
Sqlite: Update northwind.db #16242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
commented
Jun 25, 2019
| // NB: SQLite doesn't support decimal very well | ||
| modelBuilder.Entity<Order>().Property(o => o.Freight).HasConversion<double?>(); | ||
| modelBuilder.Entity<OrderDetail>().Property(o => o.UnitPrice).HasConversion<double>(); | ||
| modelBuilder.Entity<Product>().Property(o => o.UnitPrice).HasConversion<double?>(); |
There was a problem hiding this comment.
We OrderBy these in a few places which started producing wrong results when I fixed the database.
bricelam
commented
Jun 25, 2019
test/EFCore.Sqlite.FunctionalTests/Query/SimpleQuerySqliteTest.cs
Outdated
Show resolved
Hide resolved
|
@smitpatel @maumar Is there anything we want to add to the SQLite version of Northwind? I noticed it didn't have any views... |
ajcvickers
approved these changes
Jun 25, 2019
bricelam
changed the title
bricelam
changed the title
|
Updated. It's now a full port of Northwind (minus sprocs of course) |
AndriySvyryd
approved these changes
Aug 27, 2019
This is a full port of the database using our current mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the database didn't match the model in a few places.