Repair and disable failing benchmarks #16173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jun 20, 2019
Our current query pipeline makes some benchmarks fail. Unfortunately the ASP.NET perf lab currently ignores the entire benchmark suite if any benchmark fails, so disabled those benchmarks for now. Also modified benchmarks to access int rather decimal (the latter is limited on Sqlite).
smitpatel
approved these changes
Jun 20, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current query pipeline makes some benchmarks fail. Unfortunately the ASP.NET perf lab currently ignores the entire benchmark suite if any benchmark fails, so disabled those benchmarks for now. This should allow us to start tracking some basic query scenarios.
Also modified benchmarks to access int rather decimal (the latter is limited on Sqlite).
We may want to add some more benchmarks - will look into this at some point (but if someone has ideas...).
FYI to manually run benchmarks on the console, just go into benchmark/EFCore.Sqlite.Benchmarks and do
dotnet run -c Release -f netcoreapp3.0 -- --inProcess. You can add--filterto invoke a specific suite or method.