Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conventions public #15886

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Make conventions public #15886

merged 1 commit into from
Jun 1, 2019

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented May 31, 2019

Use a parameter object for all convention constructors and IModelSource.GetModel().
Move ValidationConvention to ProviderConventionSetBuilder.
XML docs will be added in a separate PR.

Part of #214
Part of #15662

Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Use a parameter object for all convention constructors and IModelSource.GetModel()
Move ValidationConvention to ProviderConventionSetBuilder

Part of #214
Part of #15662
@AndriySvyryd AndriySvyryd merged commit b6be9f7 into master Jun 1, 2019
@ghost ghost deleted the Issue214_Part7 branch June 1, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants