Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Microsoft.Data.SqlClient #15761

Merged
merged 1 commit into from
May 24, 2019
Merged

Switch to Microsoft.Data.SqlClient #15761

merged 1 commit into from
May 24, 2019

Conversation

ajcvickers
Copy link
Member

Fixes #15636

@ajcvickers ajcvickers requested a review from dougbu as a code owner May 20, 2019 18:19
bricelam
bricelam approved these changes May 20, 2019
View reviewed changes
eng/Versions.props
@@ -27,6 +27,7 @@
<StyleCopAnalyzersPackageVersion>1.1.1-beta.61</StyleCopAnalyzersPackageVersion>
<SystemInteractiveAsyncPackageVersion>3.2.0</SystemInteractiveAsyncPackageVersion>
<BenchmarkDotNetPackageVersion>0.11.3</BenchmarkDotNetPackageVersion>
<MicrosoftDataSqlClientPackageVersion>1.0.19128.1-Preview</MicrosoftDataSqlClientPackageVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙄 SemVer much?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Please file an issue on the SqlClient repo.

@natemcmaster
Copy link
Contributor

Heads up @aspnet/build - this will break aspnet/AspNetCore once merged since our dependency on System.Data.SqlClient is transitive through EF.

@ilmax
Copy link
Contributor

ilmax commented May 21, 2019

Just curious about this Microsoft.Data.SqlClient, is it a copy of System.Data.SqlClient at a given point in time or is it a rewrite from the ground up?

@smitpatel
Copy link
Member

smitpatel commented May 21, 2019 •
edited
Loading

@ilmax - It is rewrite from the ground up.

Got confused with Sqlite. Sorry

@divega
Copy link
Contributor

divega commented May 21, 2019 •
edited
Loading

@ilmax, @smitpatel It is a copy with namespace changes. Currently it is a super set, as fixes in System.Data.SqlClient done in CoreFx are being ported to the Microsoft.Data.SqlClient, and the latter contains a few new features.

See https://devblogs.microsoft.com/dotnet/introducing-the-new-microsoftdatasqlclient/ for more information.

@natemcmaster natemcmaster mentioned this pull request May 21, 2019
Closed
@ilmax
Copy link
Contributor

ilmax commented May 21, 2019

@divega nice, thanks for the link! One last question. I know @Wraith2 made several perf related changes in System.Data.SqlClient, are we gonna benefit from these changes in M.D.S as well (if applicable)?

bricelam
bricelam reviewed May 21, 2019
View reviewed changes
eng/Versions.props Outdated Show resolved Hide resolved
@divega
Copy link
Contributor

divega commented May 22, 2019

@ilmax the SqlClient team has ported all of @Wraith2's optimizations to the new codebase.

@ajcvickers
Copy link
Member Author

This is currently blocked until I can get dotnet/aspnetcore#10300 merged. So far I have failed to get the ASP.NET build to pass.

@dougbu
Copy link
Member

dougbu commented May 24, 2019

This isn't blocked anymore. Clearing that label

@dougbu dougbu removed the blocked label May 24, 2019
@ajcvickers ajcvickers force-pushed the MeetTheNewBossSameAsTheOldBoss0520 branch from 8680393 to 7f423c8 Compare May 24, 2019 18:02
@ajcvickers ajcvickers merged commit 10e553a into master May 24, 2019
@ghost ghost deleted the MeetTheNewBossSameAsTheOldBoss0520 branch May 24, 2019 19:24
@ajcvickers ajcvickers mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

@divega divega divega approved these changes

@dougbu dougbu Awaiting requested review from dougbu

@roji roji Awaiting requested review from roji

@AndriySvyryd AndriySvyryd Awaiting requested review from AndriySvyryd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to Microsoft.Data.SqlClient
7 participants
@ajcvickers @natemcmaster @ilmax @smitpatel @divega @dougbu @bricelam