Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store check constraint annotations on entity type instead of model #15688

Merged
merged 1 commit into from
May 15, 2019
Merged

Store check constraint annotations on entity type instead of model #15688

merged 1 commit into from
May 15, 2019

Conversation

Muppets
Copy link
Contributor

@Muppets Muppets commented May 10, 2019

Summary of the changes

  • Added check constraint generation to CSharpSnapshotGenerator.cs

Fixes #15676

@AndriySvyryd AndriySvyryd mentioned this pull request May 10, 2019
Closed
@Muppets Muppets mentioned this pull request May 12, 2019
Closed
@Muppets Muppets changed the title Store check constraints in the snapshot as Fluent API Store check constraint annotations on entity type instead of model May 12, 2019
@Muppets
Copy link
Contributor Author

Muppets commented May 12, 2019

@AndriySvyryd Can you take another look at this now the annotations are stored on entity types?

@AndriySvyryd
Copy link
Member

Also please rebase and squash commits

@Muppets Muppets force-pushed the issue15676-store-check-constraints-in-snapshot branch from 67c8e9b to dbb205c Compare May 14, 2019 21:47
@AndriySvyryd
Copy link
Member

@Muppets Seems that some tests need to be updated.

@Muppets Muppets force-pushed the issue15676-store-check-constraints-in-snapshot branch from ca0946f to 8fdea84 Compare May 15, 2019 19:41
@Muppets
Copy link
Contributor Author

Muppets commented May 15, 2019

@AndriySvyryd Good to go!

@AndriySvyryd AndriySvyryd merged commit 8072f34 into dotnet:master May 15, 2019
@AndriySvyryd
Copy link
Member

@Muppets Thanks for your contribution!

@ajcvickers ajcvickers mentioned this pull request May 16, 2019
Closed
@Muppets Muppets deleted the issue15676-store-check-constraints-in-snapshot branch May 16, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store check constraints in the snapshot as Fluent API
2 participants
@Muppets @AndriySvyryd