Address API Review feedback #15661
Merged
Address API Review feedback #15661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, @AndriySvyryd has more pending in his Issue214_Part5 branch. |
AndriySvyryd
reviewed
May 8, 2019
| @@ -52,15 +52,23 @@ Microsoft.Data.Sqlite.SqliteTransaction</Description> | |||
| <AutoGen>True</AutoGen> | |||
| <DependentUpon>Resources.Designer.tt</DependentUpon> | |||
| </Compile> | |||
| <Compile Update="SqliteCommand.cs"> | |||
There was a problem hiding this comment.
Does VS do this automatically? If so, is there any point fighting it?
There was a problem hiding this comment.
Don't fight it. We'll change them to <SubType>Code</SubType> to make the dev experience better as soon as the project system stops stomping over it.
AndriySvyryd
reviewed
May 8, 2019
| </Compile> | ||
| <Compile Update="SqliteConnection.CreateFunction.cs"> | ||
| <DesignTime>True</DesignTime> | ||
| <AutoGen>True</AutoGen> | ||
| <DependentUpon>SqliteConnection.CreateFunction.tt</DependentUpon> | ||
| <SubType>Component</SubType> | ||
| </Compile> | ||
| <Compile Update="SqliteConnection.cs"> |
AndriySvyryd
approved these changes
May 8, 2019
ajcvickers
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15662