Query: Dedupe & simplify materializer

[smitpatel]

No description provided.

[smitpatel]

Query like this

        [ConditionalTheory]
        [MemberData(nameof(IsAsyncData))]
        public virtual Task Join_customers_orders_entities_same_entity_twice(bool isAsync)
        {
            return AssertQuery<Customer, Order>(
                isAsync,
                (cs, os) =>
                    from c in cs
                    join o in os on c.CustomerID equals o.CustomerID
                    select new
                    {
                        A = c,
                        B = c
                    },
                e => e.A.CustomerID + " " + e.B.CustomerID,
                entryCount: 89);
        }

(c is referenced twice)
generates following shaper expression

(QueryContext queryContext | DbDataReader dataReader) => 
{
    return 
    {
        entity0 = 
        {
            entry1 = InternalEntityEntry queryContext.StateManager.TryGetEntry(
            |__ key: Key: Customer.CustomerID PK, 
            |__ keyValues: new object[]{ (object)string dataReader.GetString(0) }, 
            |__ throwOnNullKey: True, 
            |__ hasNullKey: hasNullKey1)
            return hasNullKey1 ? null : entry1 != null ? (Customer)entry1.Entity : 
            {
                materializationContext1 = new MaterializationContext(
                    ValueBuffer, 
                    queryContext.Context
                )
                instance1 = new Customer(
                    materializationContext1.Context, 
                    ILazyLoader GetService((IInfrastructure<IServiceProvider>)materializationContext1.Context), 
                    string dataReader.GetString(0)
                )
                instance1.Context = (materializationContext1.Context as NorthwindContext)
                instance1.<Address>k__BackingField = bool dataReader.IsDBNull(1) ? default(string) : string dataReader.GetString(1)
                instance1.<City>k__BackingField = bool dataReader.IsDBNull(2) ? default(string) : string dataReader.GetString(2)
                instance1.<CompanyName>k__BackingField = bool dataReader.IsDBNull(3) ? default(string) : string dataReader.GetString(3)
                instance1.<ContactName>k__BackingField = bool dataReader.IsDBNull(4) ? default(string) : string dataReader.GetString(4)
                instance1.<ContactTitle>k__BackingField = bool dataReader.IsDBNull(5) ? default(string) : string dataReader.GetString(5)
                instance1.<Country>k__BackingField = bool dataReader.IsDBNull(6) ? default(string) : string dataReader.GetString(6)
                instance1.<Fax>k__BackingField = bool dataReader.IsDBNull(7) ? default(string) : string dataReader.GetString(7)
                instance1.<Phone>k__BackingField = bool dataReader.IsDBNull(8) ? default(string) : string dataReader.GetString(8)
                instance1.<PostalCode>k__BackingField = bool dataReader.IsDBNull(9) ? default(string) : string dataReader.GetString(9)
                instance1.<Region>k__BackingField = bool dataReader.IsDBNull(10) ? default(string) : string dataReader.GetString(10)
                void queryContext.StartTracking(
                    entityType: EntityType: Customer, 
                    entity: instance1, 
                    valueBuffer: new ValueBuffer(new object[]{ }))
                return instance1
            }
        }
        return new { 
            A = entity0, 
            B = entity0
         }
    }
}

[smitpatel]

Shaper when projection in above query is new { c, o }

(QueryContext queryContext | DbDataReader dataReader) => 
{
    return new { 
        c = 
        {
            entry1 = InternalEntityEntry queryContext.StateManager.TryGetEntry(
            |__ key: Key: Customer.CustomerID PK, 
            |__ keyValues: new object[]{ (object)string dataReader.GetString(0) }, 
            |__ throwOnNullKey: True, 
            |__ hasNullKey: hasNullKey1)
            return hasNullKey1 ? null : entry1 != null ? (Customer)entry1.Entity : 
            {
                materializationContext1 = new MaterializationContext(
                    ValueBuffer, 
                    queryContext.Context
                )
                instance1 = new Customer(
                    materializationContext1.Context, 
                    ILazyLoader GetService((IInfrastructure<IServiceProvider>)materializationContext1.Context), 
                    string dataReader.GetString(0)
                )
                instance1.Context = (materializationContext1.Context as NorthwindContext)
                instance1.<Address>k__BackingField = bool dataReader.IsDBNull(1) ? default(string) : string dataReader.GetString(1)
                instance1.<City>k__BackingField = bool dataReader.IsDBNull(2) ? default(string) : string dataReader.GetString(2)
                instance1.<CompanyName>k__BackingField = bool dataReader.IsDBNull(3) ? default(string) : string dataReader.GetString(3)
                instance1.<ContactName>k__BackingField = bool dataReader.IsDBNull(4) ? default(string) : string dataReader.GetString(4)
                instance1.<ContactTitle>k__BackingField = bool dataReader.IsDBNull(5) ? default(string) : string dataReader.GetString(5)
                instance1.<Country>k__BackingField = bool dataReader.IsDBNull(6) ? default(string) : string dataReader.GetString(6)
                instance1.<Fax>k__BackingField = bool dataReader.IsDBNull(7) ? default(string) : string dataReader.GetString(7)
                instance1.<Phone>k__BackingField = bool dataReader.IsDBNull(8) ? default(string) : string dataReader.GetString(8)
                instance1.<PostalCode>k__BackingField = bool dataReader.IsDBNull(9) ? default(string) : string dataReader.GetString(9)
                instance1.<Region>k__BackingField = bool dataReader.IsDBNull(10) ? default(string) : string dataReader.GetString(10)
                void queryContext.StartTracking(
                    entityType: EntityType: Customer, 
                    entity: instance1, 
                    valueBuffer: new ValueBuffer(new object[]{ }))
                return instance1
            }
        }, 
        o = 
        {
            entry2 = InternalEntityEntry queryContext.StateManager.TryGetEntry(
            |__ key: Key: Order.OrderID PK, 
            |__ keyValues: new object[]{ (object)int dataReader.GetInt32(11) }, 
            |__ throwOnNullKey: True, 
            |__ hasNullKey: hasNullKey2)
            return hasNullKey2 ? null : entry2 != null ? (Order)entry2.Entity : 
            {
                materializationContext2 = new MaterializationContext(
                    ValueBuffer, 
                    queryContext.Context
                )
                instance2 = new Order()
                instance2.<OrderID>k__BackingField = int dataReader.GetInt32(11)
                instance2.<CustomerID>k__BackingField = bool dataReader.IsDBNull(12) ? default(string) : string dataReader.GetString(12)
                instance2.<EmployeeID>k__BackingField = bool dataReader.IsDBNull(13) ? default(Nullable<uint>) : (Nullable<uint>)(uint)int dataReader.GetInt32(13)
                instance2.<OrderDate>k__BackingField = bool dataReader.IsDBNull(14) ? default(Nullable<DateTime>) : (Nullable<DateTime>)DateTime dataReader.GetDateTime(14)
                void queryContext.StartTracking(
                    entityType: EntityType: Order, 
                    entity: instance2, 
                    valueBuffer: new ValueBuffer(new object[]{ }))
                return instance2
            }
        }
     }
}

[natemcmaster]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).