Revert ef6.exe to .NET Core 3.0 #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
commented
Oct 25, 2019
This comment has been minimized.
This comment has been minimized.
|
Cleaned up my machine and the errors went away. (Could have also been the rebase) |
This improves compatibility. In short, we'll compile against the lowest possible target framework and try to execute on the exact same target framework as the target project. Also forces the *.runtimeconfig.json file to be generated on class library projects. Fixes dotnet#1400
|
Note, the TFM changes slipped past me in PR #1223. Sorry for not noticing earlier |
ajcvickers
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves compatibility. In short, we'll compile against the lowest possible target framework and try to execute on the exact same target framework as the target project.
This also forces the *.runtimeconfig.json file to be generated on class library projects so we actually know the target framework.
Fixes #1400